Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMU: allow page-table loads/stores if MMU is off #1355

Merged
merged 1 commit into from
Oct 21, 2014

Conversation

FioraAeterna
Copy link
Contributor

Fixes regressions in some games that apparently required this to work, but
don't really require full MMU emulation (e.g. with exceptions and all).

Fixes regressions in some games that apparently required this to work, but
don't really require full MMU emulation (e.g. with exceptions and all).
@FioraAeterna
Copy link
Contributor Author

Attempt at an explanation: the patch that disabled MMU loads in non-MMU mode treated MMU as equivalent to "page table support". But some games use page tables but don't need full MMU mode (e.g. F-Zero GX) because they don't need the full exception support and all that jazz. So we want to let them still use the MMU path; otherwise we'd have to enable the full MMU mode for those games even though they don't need it.

comex added a commit that referenced this pull request Oct 21, 2014
MMU: allow page-table loads/stores if MMU is off
@comex comex merged commit 9adf608 into dolphin-emu:master Oct 21, 2014
@phire
Copy link
Member

phire commented Oct 21, 2014

Ok, The Enable MMU option is badly misnamed.

It has nothing to do with MMU and really should be renamed something like "Enable Data Exceptions"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants