Added a check for external exceptions that have been set #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false positive log message.
|
The log message is indeed wrong, but as far as I can tell, CheckExternalExceptions doesn't get called by JIT code before checking whether there are actually any exceptions. If the message is being triggered, could it mean Exceptions is racing or being unset somehow, or maybe I'm just getting confused? :) |
|
I guess it's possible for the bit to be unset by the GPU thread in weird cases. |
comex
added a commit
that referenced
this pull request
Oct 25, 2014
Added a check for external exceptions that have been set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a false positive log message.