Fixes ARM CPU detection routine for the hardware. #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't dropping a newline character from the string, we were cutting off the last character of the hardware name. This fixes my TK1 being called 'lagun' when it's name is 'laguna'
|
Shouldn't we rather check for a newline and drop that then? That code must have been there for a reason. Something like trim or chomp that gets rid of it? |
|
You say it must have been there for a reason, but I wrote the code so it probably wasn't a good reason. |
|
Uh okay, fine by me then :) |
Sonicadvance1
added a commit
that referenced
this pull request
Oct 27, 2014
Fixes ARM CPU detection routine for the hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't dropping a newline character from the string, we were cutting off the last character of the hardware name.
This fixes my TK1 being called 'lagun' when it's name is 'laguna'