DVDInterface: Tweak speeds #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be tested against the timing issues in StarFox Adventures that was already fixed. Thanks for the accuracy improvements :D |
|
LGTM if it doesn't break the StarFox timings. |
|
@dolphin-emu-bot rebuild |
|
Can you test this? @JMC47 |
|
I was asked to test this a while ago and got distracted. Sorry about that. Mario Golf + Gauntlet's videos still work fine. |
|
I guess this can be merged now, right? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ratio between the speeds at the start and end needs to be equal to the ratio between the diameters of the start and end. Previously, I got these diameters by measuring discs with a ruler. The diameters defined in ECMA-267 are now used instead, resulting in a more accurate and slightly smaller ratio. (Previously part of the closed PR 1617.)