TLB: fix backwards exception check #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skidau
added a commit
that referenced
this pull request
Dec 4, 2014
TLB: fix backwards exception check
|
Rogue Leader breaks with this change. |
|
Ugh. does this mean that the TLB code is sufficiently wrong that merely having it on breaks MMU games? :-/ and the "fast tlb cache" change only worked because it accidentally disabled the TLB? blehhhhhhhh I'm going to go play Persona Q for the week instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code basically had the TLB off, which doesn't really make any sense...?
FLAG_NO_EXCEPTION is for "fake" reads/writes generated by the emulator itself, not the real ones, as far as I remember...