Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: remove unnecessary uses of the bMMU flag #1647

Merged
merged 2 commits into from Dec 7, 2014
Merged

Cleanup: remove unnecessary uses of the bMMU flag #1647

merged 2 commits into from Dec 7, 2014

Conversation

magumagu
Copy link
Contributor

@magumagu magumagu commented Dec 4, 2014

Cleanup; the only functional change is a minor performance optimization for MMIO in bMMU mode.

I'm trying to clarify what exactly bMMU means; as far as I can tell, it means the following:

  1. Generate DSI exceptions. (js.memcheck etc.).
  2. Generate ISI exceptions. At least, I think that's the intent; we check bMMU in half a dozen places related to instruction fetch, and there aren't any comments explaining why.
  3. Turn off the FakeVMem region.

skidau
skidau reviewed Dec 4, 2014
View reviewed changes
Source/Core/Core/HLE/HLE.cpp
@@ -143,9 +143,6 @@ int GetFunctionFlagsByIndex(u32 index)

bool IsEnabled(int flags)
{
if (flags == HLE::HLE_TYPE_MEMORY && SConfig::GetInstance().m_LocalCoreStartupParameter.bMMU)

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Sonicadvance1 added a commit that referenced this pull request Dec 7, 2014
@Sonicadvance1
Merge pull request #1647 from magumagu/mmu-flag-cleanup
6d6b425 
Cleanup: remove unnecessary uses of the bMMU flag
@Sonicadvance1 Sonicadvance1 merged commit 6d6b425 into dolphin-emu:master Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@magumagu @skidau @Sonicadvance1