Moved projection epsilon back to g_fProjectionMatrix[15] #1656
Conversation
…tially scales vertices instead of just biasing.
|
This seems to fix things on all sides. |
|
The commit before you moved the projection is what I had tested everything on. I assumed incorrectly that it wouldn't have mattered. |
|
Same with me. I didn't test on the latest build of the other PR. |
|
Yeah, I did not expect it to make a significant difference :( |
|
Either way, I retested all of the titles showing regressions and everything works now. Games that used to need the Sonic Unleashed hack still work as well. This is a 100% LGTM. |
|
Things look good here too. |
|
All game working on my front too. |
|
As this is only a revert of the second commit: LGTM |
Moved projection epsilon back to g_fProjectionMatrix[15]
|
@kayru: I know it's been a while, but one of the games I got for Christmas happened to be Sonic Unleashed. Unlike all of the other games affected by the Sonic Unleashed Hack and the Projection Matrix Epsilon, it's actually not fixed. I think there needs to be more investigation into this particular game and why it's not rendering. |
|
Jmc47 here it renders fine in latest master both with d3d and opengl. |
|
Are you sure you don't have a projection hack in the ini? If you don't, |
|
Yes i don't have and that was the same in the past revisions since this was implemented, not only the latest, i have a feeling by your saying that perhaps you have a bad dump. |
|
That's impossible; I just dumped it and verified it. I literally got the disc for Christmas, and it works in the Sonic Unleashed Hack enabled builds. |
|
Well here is a pic if you don't believe me: http://prntscr.com/5nxj11 . |
|
Was Sonic Unleashed's INI ever updated. I'm the dumbass with the projection hack in the INI. Sorry :( |
|
Oh ok. |
|
I just updated my sys folder not long ago; was Sonic Unleashed's INI ever updated? If so, then I'm really sorry for posting this at all. Thanks for dealing with my momentary (permanent?) lapse in judgment and thinking. |
|
The projection hack being enabled in the default ini was removed after the dx9 removal thousands of revisions ago. Except if you enabled it locally. |
|
That's weird; I just got this game and loaded it into a new Dolphin file and it was there. I'm blaming user error then! Thanks for the help; you saved me a lot of trouble and dumbness. |
|
From the RSVE8P.ini file within the sys folder of 4.0-4889. PH_ZNear = 20 Is that not the sonic unleashed hack? And here it is in the source code -> https://github.com/dolphin-emu/dolphin/blob/9f86d3efcf1f687f5cfbe69b081aeeedb0cb9bb9/Data/Sys/GameSettings/RSVE8P.ini |
|
The important part is: |
|
It's definitely enabled by default for me; downloaded a fresh version and tried it. |
|
It was removed from PAL's GameINI, but not from the NTSC. Here's PAL -> https://github.com/dolphin-emu/dolphin/blob/9f86d3efcf1f687f5cfbe69b081aeeedb0cb9bb9/Data/Sys/GameSettings/RSVP8P.ini |
|
Guys, see my comment above, it is disabled by default, just the values stayed there in case someone needed to use it. I can remove those too if you want too though. |
|
So it's not supposed to break? Well... it did. Any discussion as for why is academic: we have a game that's totally broken here! Just remove the projection hack from the NTSC gameini, it isn't supposed to be there in the first place. |
|
I can't reproduce it here using 4.0 - 4889, sure you don't have ProjectionHack = 1 in your local ini to override it? As i said i don't have a problem to remove it, it is just good to know what is exactly wrong if anything... There are other games like that too that might be affected by such a bug. |
|
My local INI is totally empty. The hack needs to be removed regardless; it now breaks the game. Can't you just remove it from the INI altogether? That way there will be no confusion moving forward. |
|
Hmm, jmc could you test a few more games for me in case you have them to see if they suffer from the same issue? I will list them in a bit... |
|
Yeah, sure. Do note this doesn't happen in Sonic Colors or F-Zero GX, or a bunch of other of the Sonic Unleashed hack games; which is why this caught me off guard. Edit: I downloaded master once, and I noticed everything was rendering, and was like, huh? I checked the INI, and it was like you said. I went off to do some zfreeze testing, went back to master, and got a black screen again with the default INI. I have nfi what's going on now. |
|
For starters does GQSEAF Tales of symphonia have the old projection hack working by default? (The main menu won't show up). |
|
Like I said (and likely you missed because I edited my post just as you posted), something weird is happening with some of hte old projection hacks with me testing all these different builds, I think. I may be in error again. Anyway, do whatever you want with the projection hacks; if it's a problem with my system I know how to work around it now. Edit 2: And no, it's not doing this in Tales of Symphonia; that seems fine. |
|
Do you build on your own or use the buildbot builds? I am using the buildbot here. Also do you use new folders instead of overriding the folder? |
|
Mixed; Buildbot builds and builds I've had to build myself. Like I said, I'm more and more thinking a casual user won't run into whatever shenanigans happened here. |
|
projectionhack = 0 should probably not be relied upon from now on. Best to delete the hacks entirely? |
|
Majoroesch if you also have this bug is it only with this game? I don't know whether i should remove all of them or just this one. Is GQSEAF Tales of symphonia also fine for you with no main menu options missing? I suggest Tales of symphonia since it is one of the few you can easily track whether the projection hack is enabled by such a bug. |
... which essentially scales vertices instead of just biasing.
Simple bias seems to break quite a lot of games, reported in #1366.