New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: use fastmem loads in MMU mode. #1693
Conversation
Even in games that require MMU mode, loads outside the area specified by the BAT are rare, so fastmem is a substantial improvement. All of the interesting changes are in the backpatch handler, to make it generate DSI exceptions correctly.
cd19b23
to
43d56fe
Compare
This fixes a lot of the crashes in True Crime: New York City when interacting with objects. @JMC47 Can you test medabots if it behaves differently. Edit: Tested with MMU on And BAT enabled. |
No, it behaves exactly the same as before. You can tell in the tutorial. |
Have tested this out with RS2, RS3, TimeSplitters 3, GUN, Ultimate Spider-man, Spider-man 2, F-ZERO GX in MMU mode and MGS:TS in MMU mode. All games run fine. |
@JMC47 Had you meant the tutorial when testing Medabots, to be sure? |
I was talking about True Crime. I will check medabots. Thanks. Yeah, no Medabots is a GPU crash; it works fine on Software renderer. |
@JMC47 It does behave differently if you don't believe me try enter the kitchen like I reported on Issue 7230 |
The kitchen crash and the one in that report are different. If one of them are fixed, that's great, but this one in the issue as a CPU/GPU timing issue, and has nothing to do with MMU. @skidau dug into the game and determined that it shouldn't ever need full MMU at all; and any fixes by this are likely due to fallbacks used in MMU mode. |
@JMC47 Forget the kitchen or tutorial or anything they are the same issue really. There a bunch more areas where it will crash with the same error addresses. |
I've spent more time than I'd care to admit researching the problems that True Crime: New York City has. Way too much time. While I can't say with certainty I'm correct; only Fiora's dual-issue hack and the vbeam speedhack affect the behavior of the crashes that I'm able to reproduce 100% of the time. |
@JMC47 Load some of the debug levels prior to this change some of them will crash 100% of the time after this change the great majority of them work now. |
JIT: use fastmem loads in MMU mode.
Even in games that require MMU mode, loads outside the area specified by the BAT are rare, so fastmem is a substantial improvement.
All of the interesting changes are in the backpatch handler, to make it generate DSI exceptions correctly.