[AArch64] Optimization in the dispatcher. #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
AArch64_dispatcher_optimization
branch
from
e65f50e
to
8058392
Compare
|
Did i! |
|
Not to nitpick too much, but shouldn't it be a global constant? As in, we'll probably need it elsewhere much like x86's JIT ended up needing it |
|
The only time I need to unconditionally flush all the callee saved registers is in the dispatcher. |
|
What if there's a vertexjit, or etc.? Well, in ppsspp we save individually based on what regs we use anyway, but something like -[Unknown] |
|
Currently the chance of having an AArch64 vertex JIT is very low. |
Align our dispatcher to a page so we can jump to it with a ADRP+BR pair instead of ADRP+ADD+BR. Also make sure to save /all/ of our callee saved registers that we are supposed to save. Requires PR dolphin-emu#1705 prior to merging.
Sonicadvance1
force-pushed
the
AArch64_dispatcher_optimization
branch
from
8058392
to
360cf76
Compare
Sonicadvance1
added a commit
that referenced
this pull request
Dec 22, 2014
…zation [AArch64] Optimization in the dispatcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align our dispatcher to a page so we can jump to it with a ADRP+BR pair instead of ADRP+ADD+BR.
Also make sure to save /all/ of our callee saved registers that we are supposed to save.
Requires PR #1705 prior to merging.