Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometryShaderManager: Set stereo parameters in a SetConstants() call. #1734

Merged
merged 1 commit into from Dec 20, 2014

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Dec 20, 2014

Doing it in SetProjectionChanged() is too early because the projection type is not set yet.

{
s_projection_changed = false;

if (g_ActiveConfig.iStereoMode > 0 && xfmem.projection.type == GX_PERSPECTIVE)

This comment was marked as off-topic.

Doing it in SetProjectionChanged() is too early because the projection type is not set yet.
@degasus
Copy link
Member

degasus commented Dec 20, 2014

LGTM

degasus added a commit that referenced this pull request Dec 20, 2014
GeometryShaderManager: Set stereo parameters in a SetConstants() call.
@degasus degasus merged commit 9122c86 into dolphin-emu:master Dec 20, 2014
@CrossVR CrossVR deleted the stereo-fixes branch December 20, 2014 16:53
@feilen feilen mentioned this pull request Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants