Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword "Boot from DVD Drive" -> "DVD Backup" menu option #1779

Merged
merged 1 commit into from Feb 10, 2015

Conversation

riking
Copy link
Contributor

@riking riking commented Dec 28, 2014

Text change after seeing confusion in https://code.google.com/p/dolphin-emu/issues/detail?id=8007

@Buddybenj
Copy link
Contributor

Don't change the translation files; they're updated automatically through Transifex.

IMO, I think "Boot from backup DVD" makes more sense, but maybe other people disagree.

@riking
Copy link
Contributor Author

riking commented Dec 28, 2014

Don't change the translation files; they're updated automatically through Transifex.

Hm. Won't that break the UI (in other languages) until the new key is pushed to transifex then the new translations are pulled again?

@JosJuice
Copy link
Member

I'm not sure if the majority of users know what backup means in this context, but this is definitely an improvement.

As for Transifex: I'm not sure how things work over there, but maybe translators won't see that there is a new string to translate if you do it like this? Many other parts of the UI already have the problem of untranslated text anyway, so it doesn't matter too much if this string also breaks.

@riking
Copy link
Contributor Author

riking commented Dec 28, 2014

Okay, changed it to only change the string in the source.

@waddlesplash
Copy link
Contributor

LGTM

@riking riking changed the title Reword "Boot from DVD Drive" -> "Backup" menu option Reword "Boot from DVD Drive" -> "DVD Backup" menu option Jan 5, 2015
@robertybob
Copy link

Is there any news on when this'll be merged?

@Buddybenj
Copy link
Contributor

Bump.

@Buddybenj
Copy link
Contributor

Double Bump™.

magumagu added a commit that referenced this pull request Feb 10, 2015
Reword "Boot from DVD Drive" -> "DVD Backup" menu option
@magumagu magumagu merged commit 1acd80f into dolphin-emu:master Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants