Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameini updates. #1802

Merged
merged 2 commits into from Jan 4, 2015
Merged

Gameini updates. #1802

merged 2 commits into from Jan 4, 2015

Conversation

Linktothepast
Copy link
Contributor

Update/addition of Madden NFL 06 (gc), Frogger Beyond (gc), DONKEY
KONGA (gc), Madden NFL 2005 (gc), NBA STREET Vol.2 (gc), Spider-Man
(gc), Star Wars: Rogue Leader (gc), NO MORE HEROES (wii), Super Smash
Bros. Brawl (wii), The Simpsons Game (wii), Suzumiya Haruhi no Heiretsu
(wii).

Fixes issues 7978, 7894, 7883.

Update/addition of  Madden NFL 06 (gc), Frogger Beyond (gc), DONKEY
KONGA (gc), Madden NFL 2005 (gc), NBA STREET Vol.2 (gc), Spider-Man
(gc), Star Wars: Rogue Leader (gc), NO MORE HEROES (wii), Super Smash
Bros. Brawl (wii), The Simpsons Game (wii), Suzumiya Haruhi no Heiretsu
(wii).

Fixes issues 7978, 7894, 7883.
@Linktothepast
Copy link
Contributor Author

Btw this sets efb to ram as default option for Super Smash Bros. Brawl, which cuts framerate about to half of what it was. It is needed to take ingame pics and play nes masterpieces. Nes masterpiecies also need safetexture cache set to safe, but that would hamper performance even more so i didn't enable it. I thought of using texture cache in the middle which is good enough for most cases but then it would hamper those who had stc set to safe from playing them properly.

@JosJuice
Copy link
Member

JosJuice commented Jan 1, 2015

Why enable EFB to RAM in SSBB? Playing NES games is something that's done so rarely that it isn't much of an inconvenience to change a setting when you want to do it, and SSBB's screenshot tool takes images of worse quality and saves them in a more obscure way compared to Dolphin's built-in screenshot tool. I'd say that performance in the entire game is more important than being able to do these two things easily.

[Core]
# Values set here will override the main dolphin settings.
MMU = 1
FastDiscSpeed = 1

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Fuzzik
Copy link

Fuzzik commented Jan 2, 2015

I've gotta agree with JosJuice about EFB to RAM. Even with all of the neat fixes merged to make the Masterpieces work, I don't think defaulting them on is worth halving the FPS. IMO I'd just add in a note regarding that it's needed for those two features.

Remove FastDiscSpeed = 1 from Star Wars: Rogue Leader and efb to ram
from Super Smash
Bros. Brawl, put a note with suggested settings instead.
@Linktothepast
Copy link
Contributor Author

Ok done, i removed FastDiscSpeed from Rogue Leader and efb to ram from Super Smash Bros. Brawl, put a long note about it instead.

@JMC47
Copy link
Contributor

JMC47 commented Jan 2, 2015

These look good to me after a quick runthrough. I would have approved of Brawl regardless of the decision, it's such a tough one.

@PatrickFerry
Copy link
Contributor

Wait up on this I'm about to make a pull request but the game(games?) will still require Virtual XFB set.

skidau added a commit that referenced this pull request Jan 4, 2015
@skidau skidau merged commit 192c69f into dolphin-emu:master Jan 4, 2015
@Linktothepast
Copy link
Contributor Author

Oh no, i was about to push some new inis. Guess i will have to make a new pr then, sorry ZephyrSurfer, perhaps i will include changes for the zfreeze pr as well.

@cdoublejj
Copy link

Hey would I be asking too much for someone to checkout the ini for Rabbids Go Home?

https://forums.dolphin-emu.org/Thread-rabbids-go-home-issues?pid=351336#pid351336

@Linktothepast
Copy link
Contributor Author

That game has some weird performance issues that make me not want to enforce a setting. It needs xfb but anything higher than 1x ir for some reason kills performance, so i would have to choose between killing performance or killing quality by default.

@cdoublejj
Copy link

real xfb requires 1x feed back any ways. my understanding is that it needs real xfb and 1x IR. though for me real xfb made no difference i wasn't sure if it was the game or a dolphin bug. do the intro videos play corrupted and distorted for you as well?

@Linktothepast
Copy link
Contributor Author

With real xfb and safe texture cache in the middle the game plays fine here, also efb to ram is needed for some ingame functions like taking photos but that murders the framerate. With virtual xfb and any ir higher than 1x performance gets slaughtered too.
So to answer your question with real xfb and stc in the middle videos are perfectly fine here.

@cdoublejj
Copy link

Well i think i figured out why these settings were not working for me scaled EFB is enabled globally and with it off the game started working fine. it's still got crackly audio but, much better. is it possible to disable scaled EFB for rabbids and go home and set the setting you mention in the game ini?
realxfb set to ram and texture cache half way with scaled EFB disabled? other wise without these settings the game is broken, at least in the videos.

now i just need to test and see if AA and atniscropic can applied but, i wouldn't get my hopes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants