Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostProcessing: Use Dubois algorithm for anaglyph shader. #1805

Merged
merged 4 commits into from Jan 2, 2015

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jan 2, 2015

This algorithm provides a better retention of color when using Anaglyph Red-Cyan glasses.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jan 2, 2015

@degasus This PR drastically increases Anaglyph quality, could you review it?

I could also use matrix declarations here instead of vectors if that is preferred.

// "Conversion of a Stereo Pair to Anaglyph with
// the Least-Squares Projection Method"
// Eric Dubois, March 2009
static char s_anaglyph_shader[] =

This comment was marked as off-topic.

This comment was marked as off-topic.

@degasus
Copy link
Member

degasus commented Jan 2, 2015

@Armada651: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.


The matrix way LGTM

@dolphin-emu-bot allowmerge

dolphin-emu-bot added a commit that referenced this pull request Jan 2, 2015
PostProcessing: Use Dubois algorithm for anaglyph shader.
@dolphin-emu-bot dolphin-emu-bot merged commit 7dc6484 into dolphin-emu:master Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants