JIT: simplify ISI handling. #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try to JIT from a block which doesn't exist, don't JIT any code; just update the PPC state to indicate an ISI. This is a little simpler, and avoids abusing the JIT block cache.
|
Star Wars Rogue Squadron 2 still boots/plays fine with this Pull Request. Played through hoth to the best of my ability without zfreeze. Also played RS3 after being notified RS2 wasn't affected by this. Oops. |
|
Tested GUN, TimeSplitters 3, Ultimate Spider Man, Spider Man 2, F-Zero GX with MMU + BAT. All are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to JIT from a block which doesn't exist, don't JIT any code; just update the PPC state to indicate an ISI. This is a little simpler, and avoids abusing the JIT block cache.
Still needs to be tested.