MemoryUtil: add comment for Valgrind #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Could we also add such a warning if mmap fails? Else nobody will find this comment. |
Valgrind doesn't support the mmap() flag MAP_32BIT. Adding a simple CMake option would force a recompile, so just add this comment.
Sonicadvance1
added a commit
that referenced
this pull request
Jan 12, 2015
MemoryUtil: add comment for Valgrind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind doesn't support the
mmap()flagMAP_32BIT(see this bug).Alternatives that I decided not to use:
RUNNING_ON_VALGRINDmacro to decide at runtime could cause heisenbugs.