buildbot-try: allow remotes other than "origin" #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're not the only one, but I never had any trouble with that? |
|
It's not necessarily something to cause trouble (unless you don't have any remote named origin). But it might submit an unnecessarily large patch if you current origin/master is far away from the tip of the try-branch. Might also do something unexpected when you didn't fetch origin recently. |
delroth
added a commit
that referenced
this pull request
Jan 3, 2015
buildbot-try: allow remotes other than "origin"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am I the only one who likes to use the remote name "upstream" for the main repo and "origin" for my fork?