Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVDInterface: Use default delay for DVDLowClearCoverInterrupt #1838

Merged
merged 1 commit into from Jan 7, 2015

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Jan 6, 2015

The old delay was probably a hack to make up for the incorrect disc speeds. Using it with the new disc speeds made Resident Evil Archives: Resident Evil Zero freeze when starting. Fixes https://code.google.com/p/dolphin-emu/issues/detail?id=8067

The old delay was probably a hack to make up for the incorrect
disc speeds. Using it with the new disc speeds made
Resident Evil Archives: Resident Evil Zero freeze when starting.
@magumagu
Copy link
Contributor

magumagu commented Jan 6, 2015

Makes sense; LGTM. (Although it would be nice if someone could test Oregon Trail.)

@skidau
Copy link
Contributor

skidau commented Jan 6, 2015

The Oregon Trail still works with this PR.

@Buddybenj
Copy link
Contributor

LGTM

skidau added a commit that referenced this pull request Jan 7, 2015
DVDInterface: Use default delay for DVDLowClearCoverInterrupt
@skidau skidau merged commit ab87309 into dolphin-emu:master Jan 7, 2015
@JosJuice JosJuice deleted the clearcoverinterrupt-timing branch January 7, 2015 10:06
@toccata10
Copy link

It also improves a lot maddog (gunslinger): some transitions go from 24s to 3s:
https://code.google.com/p/dolphin-emu/issues/detail?id=7722
This game is so much more enjoyable now. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants