JIT: Fix the return pointer for backpatched operations. #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
isn't it supposed to return to the beginning of the jump? |
|
Err, let me try fixing the commit message; I can see that wasn't clear. The handler returns to the beginning of the jump; the trampoline returns to after the jump. |
The key change is that for stores less than 5 bytes, the correct place for the trampoline to return is immediately after the backpatched jump, not somewhere inside it.
magumagu
force-pushed
the
backpatch-padding
branch
from
afa3e08
to
c09e41d
Compare
skidau
added a commit
that referenced
this pull request
Jan 18, 2015
JIT: Fix the return pointer for backpatched operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key change is that for stores less than 5 bytes, the correct
place to return is immediately after the backpatched jump, not somewhere
inside it.