D3D: Fix Dolphin immediately exiting exclusive fullscreen. #1894
Conversation
|
@degasus Please review. |
CrossVR
force-pushed
the
exclusive-fix
branch
2 times, most recently
from
b57631f
to
87360be
Compare
CrossVR
force-pushed
the
exclusive-fix
branch
3 times, most recently
from
4006847
to
c6cd04a
Compare
| @@ -885,26 +885,21 @@ void Renderer::SwapImpl(u32 xfbAddr, u32 fbWidth, u32 fbStride, u32 fbHeight, co | |||
| { | |||
| if (fullscreen && !exclusive_mode) | |||
| { | |||
| g_Config.bExclusiveMode = false; | |||
|
|
|||
| if (g_Config.bExclusiveMode) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Allows the UI to easily check the current exclusive mode state. This simplifies a few checks and prevents the user from ever getting stuck in fullscreen.
CrossVR
force-pushed
the
exclusive-fix
branch
from
c6cd04a
to
332d588
Compare
| // Some backends don't support exclusive fullscreen, so we | ||
| // can't tell exactly when exclusive mode is activated. | ||
| if (!g_Config.backend_info.bSupportsExclusiveFullscreen) | ||
| OSD::AddMessage("Enabled exclusive fullscreen."); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Isn't it a bit noisy to generate an OSD for every fullscreen enabling/disabling? |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
@degasus It is noisy, that's why I was reluctant to add such messages. But there are no clear signs to the user exactly when exclusive mode is enabled. The only real clues are only detectable when you have two monitors. I could also just not tell them, which is what I actually prefer anyway. The only situations when exclusive mode is not enabled is when you have borderless fullscreen or Render-to-Main enabled or you are alt-tabbing out of fullscreen. |
D3D: Fix Dolphin immediately exiting exclusive fullscreen.
This PR fixes an issue reported on the forums.
I also added an OSD message to make it clear to the user when exactly exclusive mode is enabled.