Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertexLoaderX64: fix alpha of indirect 8888 colors #1925

Merged
merged 4 commits into from Jan 20, 2015
Merged

VertexLoaderX64: fix alpha of indirect 8888 colors #1925

merged 4 commits into from Jan 20, 2015

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jan 20, 2015

Also some related stuff.

magumagu
magumagu reviewed Jan 20, 2015
View reviewed changes
Source/Core/VideoCommon/VertexLoaderX64.cpp
// Resetting the alpha of 8888 when attribute != DIRECT breaks e.g.:
// - Mario Party 4 (which part?)
// - the opening menu of Xenoblade Chronicles
if (format != FORMAT_32B_8888 || (attribute == DIRECT && !elements))

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@degasus
Copy link
Member

degasus commented Jan 20, 2015

LGTM

degasus added a commit that referenced this pull request Jan 20, 2015
@degasus
Merge pull request #1925 from Tilka/vertex_loader_jit
8ff1dc9 
VertexLoaderX64: fix alpha of indirect 8888 colors
@degasus degasus merged commit 8ff1dc9 into dolphin-emu:master Jan 20, 2015
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • xenoblade-menu on ogl-lin-mesa: diff
  • xenoblade-menu on ogl-lin-nv: diff
  • xenoblade-menu on sw-lin-mesa: diff

automated-fifoci-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Tilka @degasus @dolphin-emu-bot @magumagu