Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PixelShaderGen: Fix uninitialized variables. #1929

Merged
merged 1 commit into from Jan 20, 2015
Merged

PixelShaderGen: Fix uninitialized variables. #1929

merged 1 commit into from Jan 20, 2015

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jan 20, 2015

Without this change per-pixel-lighting is broken.

@phire
Copy link
Member

phire commented Jan 20, 2015

Looks good to me.

For anyone else wondering, in the case when xfmem.numChan.numColorChans == 0 VertexShaderGen sets colors_0 and colors_1 to the vertex colour (or it defaults to float4(1.0, 1.0, 1.0, 1.0) if there is no vertex colour)

Sonicadvance1 added a commit that referenced this pull request Jan 20, 2015
@Sonicadvance1
Merge pull request #1929 from Armada651/fix-ppl
e72f70f 
PixelShaderGen: Fix uninitialized variables.
@Sonicadvance1 Sonicadvance1 merged commit e72f70f into dolphin-emu:master Jan 20, 2015
@NanoByte011
Copy link
Contributor

@phire this eliminates the one pixel shader fix I did in PR #1812, so you can take that out... there was one other one for depth, but I don't know if there is another PR that covered that one too... I probably should have made my own PR for these shader fixes as they were out of scope for zfreeze anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@CrossVR @phire @NanoByte011 @Sonicadvance1