TexCache: Rewrite the texID generation for paletted textures #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change the desciption, so it's clear that this PR contains a tiny change in behavior? I'm fine with always using the entry from the efb copy for those paletted textures. I'm not even sure the now ignored case with 2 texture cache entries could happen at all. All in all, i don't understand this well enough to argue for or against it. Thanks for cleaning up. |
degasus
changed the title
This changes the behavior if both texture are available. The old code did try to load the modfied texID, the new code tries the unmodified texID first.
degasus
added a commit
that referenced
this pull request
Jan 24, 2015
TexCache: Rewrite the texID generation for paletted textures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior if both texture are available. The old code did
try to load the modfied texID, the new code tries the unmodified texID first.