Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android cmake. #1971

Merged
merged 1 commit into from Jan 30, 2015
Merged

Conversation

Sonicadvance1
Copy link
Contributor

This is required to properly build the MIPS64 and x86_64 targets with clang.

This is required to properly build the MIPS64 and x86_64 targets with clang.
skidau added a commit that referenced this pull request Jan 30, 2015
@skidau skidau merged commit a7ab668 into dolphin-emu:master Jan 30, 2015
@Icekhaos
Copy link

Wait.

We have a MIPS port now?

@Sonicadvance1 Sonicadvance1 deleted the Android_update_cmake branch January 31, 2015 01:58
@Sonicadvance1
Copy link
Contributor Author

Nope

@fuel-pcbox
Copy link
Contributor

"This is required to properly build the MIPS64 and x86_64 targets with
clang." implies that there's a MIPS64 port.

On Fri, Jan 30, 2015 at 7:58 PM, Ryan Houdek notifications@github.com
wrote:

Nope


Reply to this email directly or view it on GitHub
#1971 (comment).

@Sonicadvance1
Copy link
Contributor Author

There isn't.

@Icekhaos
Copy link

Icekhaos commented Feb 1, 2015

Then why do we need it to build on MIPS and Intel?

@pauldacheez
Copy link
Contributor

MIPS "support" is interpreter-only and is done via the "generic" build config, which builds as long as you're building for a little-endian architecture that your compiler supports. Without a JIT, though, you can't really call an arch "supported", can you?

@Icekhaos
Copy link

Icekhaos commented Feb 1, 2015

Actually, yes, you can, but not supported by official means, rather as collateral. Provided as-is is sufficient here.

@Sonicadvance1
Copy link
Contributor Author

We test multiple build targets that we don't support purely on the basis to make sure we remain portable enough to potentially be on those platforms.
If in the future someone wants to add support, we choose to make their life easier.
Makes sure we don't have any architecture specific quirks that would impede development on a new architecture.

@Icekhaos
Copy link

Icekhaos commented Feb 1, 2015

Might then be my learning dive into MIPS.

@Sonicadvance1
Copy link
Contributor Author

There aren't any MIPS32 targets that are capable of running our OpenGL backend.
I'd recommend MIPS64 since it would be a more viable target.

@Icekhaos
Copy link

Icekhaos commented Feb 1, 2015

When the Warrior I goes into full scale production, I will probably get myself to do something about that. As is, no 64 bit MIPS processor is out.

@Sonicadvance1
Copy link
Contributor Author

Aye, which is why the AArch64 recompiler core was started under qemu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants