Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXI_DeviceAGP: Pass string by reference #1972

Merged
merged 1 commit into from Jan 30, 2015
Merged

EXI_DeviceAGP: Pass string by reference #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Source/Core/Core/HW/EXI_DeviceAGP.cpp
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@ void CEXIAgp::LoadRom()
INFO_LOG(EXPANSIONINTERFACE, "Loaded GBA sav: %s card: %d", gbapath.c_str(), m_slot);
}

void CEXIAgp::LoadFileToROM(std::string filename)
void CEXIAgp::LoadFileToROM(const std::string& filename)
{
File::IOFile pStream(filename, "rb");
if (pStream)
Expand All @@ -83,7 +83,7 @@ void CEXIAgp::LoadFileToROM(std::string filename)
}
}

void CEXIAgp::LoadFileToEEPROM(std::string filename)
void CEXIAgp::LoadFileToEEPROM(const std::string& filename)
{
File::IOFile pStream(filename, "rb");
if (pStream)
Expand All @@ -98,7 +98,7 @@ void CEXIAgp::LoadFileToEEPROM(std::string filename)
}
}

void CEXIAgp::SaveFileFromEEPROM(std::string filename)
void CEXIAgp::SaveFileFromEEPROM(const std::string& filename)
{
File::IOFile pStream(filename, "wb");
if (pStream)
Expand Down
6 changes: 3 additions & 3 deletions Source/Core/Core/HW/EXI_DeviceAGP.h
View file
Open in desktop
Expand Up @@ -47,9 +47,9 @@ class CEXIAgp
u8 m_eeprom_pos = 0;
u16 m_eeprom_cmd = 0;

void LoadFileToROM(std::string filename);
void LoadFileToEEPROM(std::string filename);
void SaveFileFromEEPROM(std::string filename);
void LoadFileToROM(const std::string& filename);
void LoadFileToEEPROM(const std::string& filename);
void SaveFileFromEEPROM(const std::string& filename);
void LoadHash();
void LoadRom();
void DoHash(u8* data, u32 size);
Expand Down