Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AArch64] Minor optimizations #1980

Merged
merged 6 commits into from Jan 30, 2015
Merged

[AArch64] Minor optimizations #1980

merged 6 commits into from Jan 30, 2015

Conversation

Sonicadvance1
Copy link
Contributor

Implements MMIO loads.
Saves overhead of flushing the destination register to the stack on loads.
Wasn't needed, was a waste of cycles.
Saves a few cycles on paired stores.

@FioraAeterna
Copy link
Contributor

Looks all pretty reasonable except for the MMIO bit, which I don't feel sufficiently C++-qualified to sign off on ;-)

@Sonicadvance1
[AArch64] Add support for MMIO loads.
c8c062f 
Should give a small performance benefit.
@Sonicadvance1
[AArch64] Don't flush VFP register to stack when not needed.
235f6c2
@Sonicadvance1
[AArch64] Minor performance improvements to paired stores.
631c8a9 
We can combine these two ST1 calls in to a single ST1 call.
Saves a few cycles in paired stores
@Sonicadvance1
Copy link
Contributor Author

Updated a small comment in the MMIO class to make it more correct

Sonicadvance1 added a commit that referenced this pull request Jan 30, 2015
@Sonicadvance1
Merge pull request #1980 from Sonicadvance1/AArch64_more_optimizations
a277172 
[AArch64] Minor optimizations
@Sonicadvance1 Sonicadvance1 merged commit a277172 into dolphin-emu:master Jan 30, 2015
@Sonicadvance1 Sonicadvance1 deleted the AArch64_more_optimizations branch January 30, 2015 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@Sonicadvance1 @FioraAeterna