Fix regression for D3D EFB depth copies. #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magumagu
force-pushed
the
d3d-efb-depth
branch
from
94cb0a4
to
d964a27
Compare
|
Does this fix an issue or game in particular? |
|
Yes, fixes a regression with Metroid Prime 2 scan visor. |
|
Fixes "some objects cannot be scanned" in Metroid 3 |
|
@magumagu If I remember correctly OpenGL sample depth texture in limunance mode, so r=g=b. Can you please try if just using "r" everywhere also works fine? I don't see why we shoud use "b" at all... |
On D3D, we read from the depth buffer using the format DXGI_FORMAT_R24_UNORM_X8_TYPELESS (essentially, the "r" component contains the depth, and the other components contain nothing).
magumagu
force-pushed
the
d3d-efb-depth
branch
from
d964a27
to
57d94de
Compare
|
Yes, using "r" works; thanks for the tip. |
degasus
added a commit
that referenced
this pull request
Feb 3, 2015
Fix regression for D3D EFB depth copies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On D3D, we read from the depth buffer using the format
DXGI_FORMAT_R24_UNORM_X8_TYPELESS (essentially, the "r" component contains
the depth).