[AArch64] Vertex loader and things #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmarks? How am I to make sure this is worth merging without benchmarks?! |
|
Don't know about the actual ARM stuff but yay! Small nit: |
| else | ||
| { | ||
| MOVI2R(scratch2_reg, 0xFFFF); | ||
| CMP(scratch1_reg, scratch2_reg); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This lets me see _assert_msg_ alerts on Android when passing dumb arguments to my AArch64 emitter.
Since I've added the msg handler. I found all these asserts that were backwards. So they were asserting on the correct arguments.
We were poisoning 4x more data and overrunning our buffers. We don't want to do this.
These will be used with the vertex loader JIT recompiler.
This reduces some dumb state shuffling when calling the emitted vertex loaders.
Sonicadvance1
force-pushed
the
AArch64_vertex_loader
branch
2 times, most recently
from
fb7a993
to
b76bf6d
Compare
Shows a noticeable reduction in time spent in the vertex loader.
These use the Vector x Element FMUL instruction to improve speeds slightly. Should give ~3cycle improvement per quantized loadstore done.
Sonicadvance1
force-pushed
the
AArch64_vertex_loader
branch
from
b76bf6d
to
2ebe57e
Compare
In nearly all direct loadstore cases we can use unscaled loadstores. Still have a fallback in case we hit a situation that we /can't/ do a unscaled loadstore.
Sonicadvance1
force-pushed
the
AArch64_vertex_loader
branch
from
955f3ad
to
ed008c3
Compare
Sonicadvance1
added a commit
that referenced
this pull request
Feb 17, 2015
[AArch64] Vertex loader and things
|
@Sonicadvance1 I think for the progress report, an ingame benchmark would also be nice... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.