D3D: Use the correct format when resolving the EFB depth texture.

[CrossVR]

No description provided.

[delroth]

What does this fix? Why?

[CrossVR]

@delroth It should fix Issue 8247.

The reason this issue exists is because GetResolvedDepthTexture() was incorrectly implemented at first where it resolved the color texture instead. This was not a problem since the function was never called. When I discovered the flaw I changed it to resolve the depth texture, but I forgot to change the format.

PR #2023 is the first PR to actually call this function and it is the cause of Issue 8247.

[delroth]

@Armada651: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.

---

OK. If user testing reports that this is fixed, feel free to merge.

@dolphin-emu-bot allowmerge

[Xcedf]

Not working, started a new game and can't scan anything in AA mode

[CrossVR]

@mrgreywater I don't know why you deleted your comment, but you're right it should've been DXGI_FORMAT_R24_UNORM_X8_TYPELESS.

[mrgreywater]

@Armada651 I removed it because the primary depth buffer itself uses R24G8, and It was more like an educated guess. Also the depth isn't correct anyways in the D3D renderer, I compared it to the software renderer and it was quite different in some occassions, both the current and inverted version.

[CrossVR]

@delroth I'll make another PR to fix Issue 8247, but I think this one should be merged regardless since the type is incorrect any way you look at it.