Remove disable efb copy #2089
Remove disable efb copy #2089
Conversation
| static wxString efb_copy_desc = wxTRANSLATE("Disable emulation of EFB copies.\nThese are often used for post-processing or render-to-texture effects, so while checking this setting may give a minor speedup over EFB to Texture it almost invariably also causes issues.\n\nIf unsure, leave this unchecked."); | ||
| static wxString efb_copy_texture_desc = wxTRANSLATE("Store EFB copies in GPU texture objects.\nThis isn't particularly accurate, but it works well enough for most games and gives a great speedup over EFB to RAM.\n\nIf unsure, leave this checked."); | ||
| static wxString efb_copy_ram_desc = wxTRANSLATE("Accurately emulate EFB copies.\nNumerous games depend on this for certain graphical effects or gameplay functionality.\nThis is much slower than EFB to Texture.\n\nIf unsure, check EFB to Texture instead."); | ||
| static wxString skip_efb_copy_to_ram_desc = wxTRANSLATE("Skip GPU syncing on EFB copys. Causes graphical defects in a small number of other games.\n\nIf unsure, leave this checked."); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
degasus
force-pushed
the
remove_disable_efb_copy
branch
from
12fa479
to
0523378
Compare
|
<3 |
|
Can we have JMC and MaJoR report if there are still some games that require this to be playable? |
|
@delroth JMC47 did ask for removing this option: https://code.google.com/p/dolphin-emu/issues/detail?id=8254 |
|
Oh. |
|
The last thing that disabling efb copies helped (that I know of) was issue 5920, and that was fixed by TFN. I can't think of any others, and some searching on the wiki didn't find any either. So I say, let's do this! |
|
Agreed, there is nothing that disabling efb copies really fix. There was also the case of resident evil code veronica in the past but that was properly fixed too. |
|
woo |
|
Resident Evil Code Veronica works with EFB2RAM and EFB2Tex. Feel free to merge. |
degasus
force-pushed
the
remove_disable_efb_copy
branch
from
0523378
to
ea29722
Compare
| header.bEFBCopyEnable = g_ActiveConfig.bEFBCopyEnable; | ||
| header.bCopyEFBToTexture = g_ActiveConfig.bCopyEFBToTexture; | ||
| header.bEFBCopyEnable = true; | ||
| header.bSkipEfbCopyToRam = g_ActiveConfig.bSkipEfbCopyToRam; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
http://hastebin.com/itipekopoc.drps |
|
@Sonicadvance1 given that the Android UI still mentions the cache option, I would rather this be all cleaned up in a separate PR. |
|
Sounds fine. |
degasus
force-pushed
the
remove_disable_efb_copy
branch
from
ea29722
to
967eaad
Compare
No description provided.