Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenGL ES 3.1 on non-Nvidia devices. #2142

Merged

Conversation

Sonicadvance1
Copy link
Contributor

We are declaring we require ARB_shader_image_load_store in the shader, this isn't an extension on GLES because it is part of the GLSL ES 3.1 spec.
If we are running as GLES then just not put it in the shaders.

@@ -556,7 +556,7 @@ void ProgramShaderCache::CreateHeader()

, GetGLSLVersionString().c_str()
, v<GLSL_140 ? "#extension GL_ARB_uniform_buffer_object : enable" : ""
, g_ActiveConfig.backend_info.bSupportsEarlyZ ? "#extension GL_ARB_shader_image_load_store : enable" : ""
, v<GLSLES_300 && g_ActiveConfig.backend_info.bSupportsEarlyZ ? "#extension GL_ARB_shader_image_load_store : enable" : ""

This comment was marked as off-topic.

This comment was marked as off-topic.

We are declaring we require ARB_shader_image_load_store in the shader, this isn't an extension on GLES because it is part of the GLSL ES 3.1 spec.
If we are running as GLES then just not put it in the shaders.
Sonicadvance1 added a commit that referenced this pull request Mar 8, 2015
Fix OpenGL ES 3.1 on non-Nvidia devices.
@Sonicadvance1 Sonicadvance1 merged commit b0f6120 into dolphin-emu:master Mar 8, 2015
@Sonicadvance1 Sonicadvance1 deleted the fix_gles31_non_nvidia branch March 8, 2015 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants