Improvements to DiscIO::CompressFileToBlob and DecompressBlobToFile #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| File::IOFile inf(infile, "rb"); | ||
| if (!inf) | ||
| { | ||
| PanicAlertT("Failed to open the input file %s.", infile.c_str()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Changed it. Thanks for the feedback. |
|
Other than that, I don't see any immediate issues code-wise (haven't tried it tho). |
|
@mickdermack would you please rebase this PR? |
mickdermack
force-pushed
the
pr-compress
branch
from
76f8db0
to
9387603
Compare
|
@skidau Done. |
|
@dolphin-emu-bot rebuild |
skidau
added a commit
that referenced
this pull request
Mar 19, 2015
Improvements to DiscIO::CompressFileToBlob and DecompressBlobToFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with CompressFileToBlob and DecompressBlobToFile.
Previously, failed writes were ignored and processing continued and showed success to the user instead of aborting with an error message (Issue 7867).
If deflateInit failed (highly unlikely), DiscScrubber::Cleanup wasn't called leading to a memory leak.
The functions now delete the output file if processing fails.
Moved the DiscScrubber setup code below the code for opening files.
Removed now unnecessary label.