Remove the "nativeLibsToJar" gradle task. #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes stuff for me. |
Sonicadvance1
added a commit
that referenced
this pull request
May 6, 2015
Remove the "nativeLibsToJar" gradle task.
|
Hm, I didn't think this would actually fix anything other than just being a bit cleaner. What are you referring to? |
|
Fixes the buildbot trying to package the libraries twice which caused a build failure earlier today. |
|
That's really weird. I took a look at that build failure; it's weird for several reasons:
Is it somehow possible that pr-android is not performing a gradle clean before building the APK? That seems the most likely explanation, and is something that we should resolve if true. |
|
It definitely isn't running a clean between PR builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary; Gradle will include any *.so files you place in the
jniLibsfolder for a given build configuration. (i.e. main vs. debug, though we don't differentiate right now.)However, this means that the native libraries must actually be placed there, so this PR modifies CMakeLists.txt to ensure that successful builds target that folder.