[ARMv7] Extend the life of the JIT Recompiler. #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until loadstores are fully investigated, let's artificially extend the life of it by disabling all of them. These instructions break in a very terrible way and eventually all loadstores end up attempting to access memory region (u32)-1. Disable until someone has enough time to investigate further.
|
Is LoadStore affected generally, or only the fastmem part of it? |
|
Both are affected equally. |
|
Haven't gotten a chance to try this yet, but does this at least work around the mmap() error? |
|
It doesn't work around the memmap error. It works around the issue that will happen if mmap would actually not fail. |
Sonicadvance1
added a commit
that referenced
this pull request
Jun 2, 2015
[ARMv7] Extend the life of the JIT Recompiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until loadstores are fully investigated, let's artificially extend the life of it by disabling all of them.
These instructions break in a very terrible way and eventually all loadstores end up attempting to access memory region (u32)-1.
Disable until someone has enough time to investigate further.