Lighting Attenuation #2471
Merged
Lighting Attenuation #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NanoByte011 Can you please review my last patch? |
|
ok good stuff, but there are a few tweaks I didn't have committed yet that fix other things (like Mario Tennis score and preview court), reviewing your code has motivated me to finish this off now, do you mind if I take it from here? |
|
@NanoByte011 you're welcome :D |
|
"attn"? u srs? |
- Fixes remaining lighting issues (Mario Tennis, etc) - Apply same fixes to Software Renderer - Corrected zero length light direction vector to resolve with normal direction (essentially becomes LIGHTDIF_NONE which was what I was after)
- Refactored Light Attenuation into inline function in Software Renderer - Corrected zero length light direction vector to resolve with normal direction (essentially becomes LIGHTDIF_NONE which was what I was after) - Change the API of this shared function to use points for output variables (degasus)
|
I've droped my last commit as it seems to not be correct. So this PR is mostly the same as NanoByte's. His changes LGTM, so ready for merging IMO. @NanoByte011 Your next changes are welcome, but I'd like to merge this here right now. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate of PR #2021
I've rebased and cleaned up the commit a bit, and added a last one to use the same normalization also for the other configurations.