Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioCommon: Remove lock on Pause state #2472

Merged
merged 1 commit into from May 30, 2015
Merged

Conversation

degasus
Copy link
Member

@degasus degasus commented May 28, 2015

We had to lock audiocommon with the old asynchron HLE audio emulation,
now our Mixer is just a plain FIFO which may underrun.
Of course, this will stutter, but underruning the audio backend is likely worse.

We had to lock audiocommon with the old asynchron HLE audio emulation,
now our Mixer is just a plain FIFO which may underrun.
Of course, this will stutter, but underruning the audio backend is likely worse.
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@delroth
Copy link
Member

delroth commented May 30, 2015

LGTM. Locking does not make much sense here -- we don't have anything to save in terms of state in the mixer.

degasus added a commit that referenced this pull request May 30, 2015
AudioCommon: Remove lock on Pause state
@degasus degasus merged commit c12f04e into dolphin-emu:master May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants