-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shaders for anaglyph Amber-Blue and Green-Magenta #2491
Conversation
I could only test the G-M because I don't have an Amber-Blue. |
Please drop the merge commit; we won't merge it like this. |
Are those |
Are we even able to use these constants? They are copywritten under "All rights reserved" which I think we aren't allowed to distribute without explicit say from the original author to do so, which breaks GPL? |
Mathematic constants aren't copyright-able, so they are fine. |
Are those shaders tested on both D3D and OGL? iirc they have some other default meaning of row vs vector based matrices :/ |
You'll have to rebase, not merge. |
I thought I did and I'm sorry for all the garbage. Can I start over? |
If you mean open a new PR, there's no need for that. Once you get it right locally, you just need to force-push. If you need help, join #dolphin-dev on freenode. |
Can you also fix the alignment? |
The way you previously did it was actually the Dolphin Way. It's just that some spaces were missing. |
lgtm |
@degasus: the different API matrix multiplications differences can be bypassed abstracting the operation. The improvements to the interface I'm working on solves the problem. |
Why is it not merged yet? |
@TijmenW The thing is I don't actually know OpenGL. While we're waiting for someone to properly review this, you could rebase the two commits into one. |
mat3 r = mat3(-0.016,-0.123,-0.017, | ||
0.006, 0.062, 0.017, | ||
-0.094,-0.185, 0.991); | ||
SetOutput(float4(c0.rgb * l + c1.rgb * r, c0.a)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
add shaders for anaglyph Amber-Blue and Green-Magenta
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
https://code.google.com/p/dolphin-emu/issues/detail?id=8388
Please ignore 9470a46