Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit64: add FMA4 support to fmaddXX #2496

Merged
merged 2 commits into from Jun 6, 2015
Merged

Jit64: add FMA4 support to fmaddXX #2496

merged 2 commits into from Jun 6, 2015

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jun 1, 2015

AMD's Bulldozer processors are the only CPUs that support FMA4 but not FMA3. I'd say we support it until it gets in the way.

@MayImilae
Copy link
Contributor

It's a performance improvement for AMD, right? If so, can we get someone with an AMD chip to test it and see how much it helps?

@Icekhaos
Copy link

Icekhaos commented Jun 2, 2015

I'm all for this. I have an FX 8150 to test this with if you are interested.

@Tilka
Copy link
Member Author

Tilka commented Jun 2, 2015

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@Icekhaos
Copy link

Icekhaos commented Jun 4, 2015

Which games are fmadd intensive?

@Tilka
Copy link
Member Author

Tilka commented Jun 4, 2015

No idea, but I'm more interested in whether this introduces any bugs/crashes rather than performance.

@Icekhaos
Copy link

Icekhaos commented Jun 4, 2015

Well, thinking back, we DID have fmadd issues with Mario Kart. Meanwhile I go looking through my brother's Wii library for it, I would like to have a console recorded playback, if that could be done.

@Tilka
Copy link
Member Author

Tilka commented Jun 5, 2015

Ping. Any issues with this? I'm going to merge this tomorrow if nothing crops up.

Tilka added a commit that referenced this pull request Jun 6, 2015
Jit64: add FMA4 support to fmaddXX
@Tilka Tilka merged commit d3e47df into dolphin-emu:master Jun 6, 2015
@Tilka Tilka deleted the fma4 branch June 6, 2015 15:31
@ghost
Copy link

ghost commented Jun 6, 2015

This apparently does cause issues: https://code.google.com/p/dolphin-emu/issues/detail?id=8640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants