New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jit64: add FMA4 support to fmaddXX #2496
Conversation
It's a performance improvement for AMD, right? If so, can we get someone with an AMD chip to test it and see how much it helps? |
62349f1
to
dbbf401
Compare
I'm all for this. I have an FX 8150 to test this with if you are interested. |
@Icekhaos Assuming you use Windows: http://dl.dolphin-emu.org/prs/pr-2496-dolphin-latest-x64.7z |
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Which games are fmadd intensive? |
No idea, but I'm more interested in whether this introduces any bugs/crashes rather than performance. |
Well, thinking back, we DID have fmadd issues with Mario Kart. Meanwhile I go looking through my brother's Wii library for it, I would like to have a console recorded playback, if that could be done. |
Ping. Any issues with this? I'm going to merge this tomorrow if nothing crops up. |
Jit64: add FMA4 support to fmaddXX
This apparently does cause issues: https://code.google.com/p/dolphin-emu/issues/detail?id=8640 |
AMD's Bulldozer processors are the only CPUs that support FMA4 but not FMA3. I'd say we support it until it gets in the way.