-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Remove the old UI, and remove support for pre-5.0 devices. #2501
Android: Remove the old UI, and remove support for pre-5.0 devices. #2501
Conversation
Is it OK if I make a pull request with my AppCompat changes now? On Mon, Jun 1, 2015, 7:58 PM Eder Bastos notifications@github.com wrote:
|
I assume what you mean by that is to switch out all the Android 5.0+ UI views with their AppCompat equivalents. The biggest thing that'll get us is the ability to run the new UI on pre-5.0 devices. I am trying to remove support for those intentionally, because any device that has a chance of running Dolphin capably will come preloaded with, or has been updated to, 5.0. I've been meaning to move to AppCompat equivalents eventually anyway, as it will add some future-proofing (and may be required to use the Design Support Library announced last week). If you've already done this, there's no reason not to submit a PR for it once this is merged. |
By the way, you don't need to ask permission to make PRs - I'd love it if the Android UI wasn't a one-man project. Join us in the IRC so we can plan things out. |
Anything blocking a merge here? I know there are still some feature-parity issues, but unless they are considered giant showstoppers I would like to have them in master so people see them / report them / have opinions about them. |
…ctivity's title to "Dolphin Emulator'
4eff89f
to
6f3279d
Compare
Android: Remove the old UI, and remove support for pre-5.0 devices.
Someone brought it up to me that the input overlay configuration no longer works. |
The new UI is effectively at feature parity and nary a soul exists who wants to work on the old one.
Let's kill it with fire, so we can move on to bigger and better things.
Edit: I should've made this clearer before, but effectively this PR will end support for Android devices running OS older than 5.0