New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Remove the old UI, and remove support for pre-5.0 devices. #2501

Merged
merged 5 commits into from Jun 9, 2015

Conversation

4 participants
@sigmabeta
Contributor

sigmabeta commented Jun 1, 2015

The new UI is effectively at feature parity and nary a soul exists who wants to work on the old one.

Let's kill it with fire, so we can move on to bigger and better things.

Edit: I should've made this clearer before, but effectively this PR will end support for Android devices running OS older than 5.0

@ds84182

This comment has been minimized.

Show comment
Hide comment
@ds84182

ds84182 Jun 2, 2015

Contributor

Is it OK if I make a pull request with my AppCompat changes now?

On Mon, Jun 1, 2015, 7:58 PM Eder Bastos notifications@github.com wrote:

The new UI is effectively at feature parity and nary a soul exists who
wants to work on the old one.

Let's kill it with fire, so we can move on to bigger and better things.

You can view, comment on, or merge this pull request online at:

#2501
Commit Summary

  • Android: Remove the old UI.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2501.

Contributor

ds84182 commented Jun 2, 2015

Is it OK if I make a pull request with my AppCompat changes now?

On Mon, Jun 1, 2015, 7:58 PM Eder Bastos notifications@github.com wrote:

The new UI is effectively at feature parity and nary a soul exists who
wants to work on the old one.

Let's kill it with fire, so we can move on to bigger and better things.

You can view, comment on, or merge this pull request online at:

#2501
Commit Summary

  • Android: Remove the old UI.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2501.

@sigmabeta

This comment has been minimized.

Show comment
Hide comment
@sigmabeta

sigmabeta Jun 2, 2015

Contributor

I assume what you mean by that is to switch out all the Android 5.0+ UI views with their AppCompat equivalents.

The biggest thing that'll get us is the ability to run the new UI on pre-5.0 devices. I am trying to remove support for those intentionally, because any device that has a chance of running Dolphin capably will come preloaded with, or has been updated to, 5.0.

I've been meaning to move to AppCompat equivalents eventually anyway, as it will add some future-proofing (and may be required to use the Design Support Library announced last week). If you've already done this, there's no reason not to submit a PR for it once this is merged.

Contributor

sigmabeta commented Jun 2, 2015

I assume what you mean by that is to switch out all the Android 5.0+ UI views with their AppCompat equivalents.

The biggest thing that'll get us is the ability to run the new UI on pre-5.0 devices. I am trying to remove support for those intentionally, because any device that has a chance of running Dolphin capably will come preloaded with, or has been updated to, 5.0.

I've been meaning to move to AppCompat equivalents eventually anyway, as it will add some future-proofing (and may be required to use the Design Support Library announced last week). If you've already done this, there's no reason not to submit a PR for it once this is merged.

@sigmabeta

This comment has been minimized.

Show comment
Hide comment
@sigmabeta

sigmabeta Jun 2, 2015

Contributor

By the way, you don't need to ask permission to make PRs - I'd love it if the Android UI wasn't a one-man project. Join us in the IRC so we can plan things out.

Contributor

sigmabeta commented Jun 2, 2015

By the way, you don't need to ask permission to make PRs - I'd love it if the Android UI wasn't a one-man project. Join us in the IRC so we can plan things out.

@sigmabeta sigmabeta changed the title from Android: Remove the old UI. to Android: Remove the old UI, and remove support for pre-5.0 devices. Jun 2, 2015

@sigmabeta

This comment has been minimized.

Show comment
Hide comment
@sigmabeta

sigmabeta Jun 6, 2015

Contributor

Anything blocking a merge here?

I know there are still some feature-parity issues, but unless they are considered giant showstoppers I would like to have them in master so people see them / report them / have opinions about them.

Contributor

sigmabeta commented Jun 6, 2015

Anything blocking a merge here?

I know there are still some feature-parity issues, but unless they are considered giant showstoppers I would like to have them in master so people see them / report them / have opinions about them.

@Parlane Parlane added the WIP label Jun 8, 2015

Sonicadvance1 added a commit that referenced this pull request Jun 9, 2015

Merge pull request #2501 from sigmabeta/android-kill-old-ui
Android: Remove the old UI, and remove support for pre-5.0 devices.

@Sonicadvance1 Sonicadvance1 merged commit 0047ea8 into dolphin-emu:master Jun 9, 2015

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on the Buildbot.
Details
pr-android Build succeeded on the Buildbot.
Details
pr-deb-dbg-x64 Build succeeded on the Buildbot.
Details
pr-deb-x64 Build succeeded on the Buildbot.
Details
pr-osx-x64 Build succeeded on the Buildbot.
Details
pr-ubu-nogui-x64 Build succeeded on the Buildbot.
Details
pr-ubu-x64 Build succeeded on the Buildbot.
Details
pr-win-dbg-x64 Build succeeded on the Buildbot.
Details
pr-win-x64 Build succeeded on the Buildbot.
Details

@sigmabeta sigmabeta deleted the sigmabeta:android-kill-old-ui branch Jun 9, 2015

@Sonicadvance1

This comment has been minimized.

Show comment
Hide comment
@Sonicadvance1

Sonicadvance1 Jun 16, 2015

Contributor

Someone brought it up to me that the input overlay configuration no longer works.
I've investigated and it looks like this one is the culprit.
Removing the old UI, managed to accidentally remove the input config overlay activity. Which is of course still required in the new UI.
If you could fix this that would be great.

Contributor

Sonicadvance1 commented Jun 16, 2015

Someone brought it up to me that the input overlay configuration no longer works.
I've investigated and it looks like this one is the culprit.
Removing the old UI, managed to accidentally remove the input config overlay activity. Which is of course still required in the new UI.
If you could fix this that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment