Fixed: NULL remoteHost in IOCTL_SO_INETATON

[sepalani]

Fix a crash when a domain name doesn't exist. (Ex: Monster Hunter Tri)

[Tilka]

Not pretty, but that's not your fault... lgtm

[sepalani]

The last value can be set to INADDR_NONE (i.e. -1) when remoteHost is NULL. I'm not a huge fan of it because it's a valid broadcast address, but it's only for INFO_LOG so it should be fine.

[Tilka]

Oh, and both the old and the current code dereference remoteHost->h_addr_list[0] and then check for null.

[BhaaLseN]

If you're doing a cleanup anyways, why not make it an if nullptr/else with two distinct logs?

[sepalani]

There is no normal way for remoteHost->h_addr_list to be NULL in most Linux implementations:
#define h_addr h_addr_list[0] /* for backward compatibility */
I don't know if that's still the case with outlandish implementation so I checked it anyway.

Otherwise, making two distinct logs can be a good idea and it would be slightly faster than those ternaries I guess. What would you advise me to do?

[BhaaLseN]

Its unlikely to be noticably any faster or slower; my argument is for readibilty.

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• line-width-test on dx-win-nv: diff

_{^{automated-fifoci-reporter}}

[sepalani]

Fine.

Looks like my first commit but with more checks which allowed to get rid of those ternaries and unnecessary string formats by the same way.

However I don't know how this kind of changes can impact graphical rendering...

[Tilka]

Ignore dx-win-nv, it's currently broken.