Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Use non-CMake tool for fixing up OS X bundles #2536

Merged
merged 3 commits into from Jun 9, 2015

Conversation

endrift
Copy link
Contributor

@endrift endrift commented Jun 6, 2015

This imports a tool I wrote for mGBA to prepare OS X app bundles for deployment by recursively importing all of the frameworks and dylibs into the Contents/Frameworks folder. It properly handles symlinks (unlike CMake, thus fixing #8445), and removes a dependency on CMake-specific functionality on the chance that CMake gets dumped.

The script works with either Python 2.7 or 3.1+.

if split[0] == '@executable_path':
split[:1] = execPath
if split[0] == '/' and not os.access(joinPath(split), os.F_OK):
split[:1] = root

This comment was marked as off-topic.

This comment was marked as off-topic.

@endrift endrift changed the title Common: Use non-CMake tool for fixing up OS X bundles Tools: Use non-CMake tool for fixing up OS X bundles Jun 6, 2015
@comex
Copy link
Contributor

comex commented Jun 7, 2015

@dolphin-emu-bot rebuild

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • ea-vp6 on ogl-lin-nv: diff
  • fortune-street-white-box on ogl-lin-nv: diff
  • megaman-heat on ogl-lin-nv: diff
  • melee-lighting on ogl-lin-nv: diff
  • mii-channel on ogl-lin-nv: diff
  • simpsons-tev on ogl-lin-nv: diff
  • smg2-fog on ogl-lin-nv: diff
  • ssbm-pointsize on ogl-lin-nv: diff

automated-fifoci-reporter

comex added a commit that referenced this pull request Jun 9, 2015
Tools: Use non-CMake tool for fixing up OS X bundles
@comex comex merged commit 9ed7e3b into dolphin-emu:master Jun 9, 2015
@endrift endrift deleted the deploy-mac branch June 9, 2015 21:58
@RainingJellyfish
Copy link

Can someone please put this into a build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants