Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "OGL: Switch depth buffers to GL_DEPTH_COMPONENT32F format."" #2541

Merged
merged 4 commits into from Jun 6, 2015

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jun 6, 2015

In the end the floating point depth buffer was more accurate, without it round-trip errors can still occur.

GL_DEPTH_COMPONENT24: https://www.dropbox.com/s/gflcz2p6yfm6frm/Schermafdruk%202015-06-06%2019.13.11.png?dl=0
GL_DEPTH_COMPONENT32F: https://www.dropbox.com/s/pxhnnceyue1srmk/Schermafdruk%202015-06-06%2020.34.58.png?dl=0

This will break mini-ninjas on mesa, but it is already broken on nvidia anyway.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • mario-tennis-menu on ogl-lin-mesa: diff
  • mini-ninjas on ogl-lin-mesa: diff
  • mkdd-efb on ogl-lin-mesa: diff
  • mkwii-bluebox on ogl-lin-mesa: diff
  • nsmbw-intro on ogl-lin-mesa: diff
  • simpsons-tev on ogl-lin-mesa: diff
  • smg2-fog on ogl-lin-mesa: diff
  • tsp3-pinkgrass on ogl-lin-mesa: diff
  • zww-water on ogl-lin-mesa: diff
  • zww-waves on ogl-lin-mesa: diff
  • chibi-robo-fastdepth on ogl-lin-nv: diff
  • chibi-robo-zfighting on ogl-lin-nv: diff
  • djfny-menu on ogl-lin-nv: diff
  • ea-vp6 on ogl-lin-nv: diff
  • ed-lighting on ogl-lin-nv: diff
  • fifa-street on ogl-lin-nv: diff
  • fortune-street-white-box on ogl-lin-nv: diff
  • kirby-shadows on ogl-lin-nv: diff
  • line-width-test on ogl-lin-nv: diff
  • luigi-shadows on ogl-lin-nv: diff
  • mario-tennis-menu on ogl-lin-nv: diff
  • megaman-heat on ogl-lin-nv: diff
  • mii-channel on ogl-lin-nv: diff
  • mini-ninjas on ogl-lin-nv: diff
  • mkdd-efb on ogl-lin-nv: diff
  • mtennis-zfreeze on ogl-lin-nv: diff
  • nfsu-purplerect on ogl-lin-nv: diff
  • nfsu-reflections on ogl-lin-nv: diff
  • nsmbw-intro on ogl-lin-nv: diff
  • rs2-zfreeze on ogl-lin-nv: diff
  • smg2-fog on ogl-lin-nv: diff
  • sw3-dt on ogl-lin-nv: diff
  • thps4-shadow on ogl-lin-nv: diff
  • tos-invis-char on ogl-lin-nv: diff
  • tsp3-pinkgrass on ogl-lin-nv: diff
  • xenoblade-menu on ogl-lin-nv: diff
  • zww-water on ogl-lin-nv: diff
  • zww-waves on ogl-lin-nv: diff

automated-fifoci-reporter

@degasus
Copy link
Member

degasus commented Jun 6, 2015

LGTM

CrossVR added a commit that referenced this pull request Jun 6, 2015
Revert "Revert "OGL: Switch depth buffers to GL_DEPTH_COMPONENT32F format.""
@CrossVR CrossVR merged commit b0afb08 into dolphin-emu:master Jun 6, 2015
@CrossVR CrossVR deleted the revert-revert branch June 6, 2015 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants