Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D: Implement Z pokes. #2550

Merged
merged 2 commits into from Jun 8, 2015
Merged

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jun 7, 2015

This also fixes an offset issue with color pokes.

This is just a quick implementation of Z pokes. It should still be expanded to support the EFB poke method used in the OGL backend.

};

if (cq_observer ||
draw_quad_data.x1 != x1 || draw_quad_data.y1 != y1 ||
draw_quad_data.x2 != x2 || draw_quad_data.y2 != y2 ||
draw_quad_data.col != Color)
draw_quad_data.col != Color || draw_quad_data.z != z)

This comment was marked as off-topic.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • chibi-robo-fastdepth on ogl-lin-nv: diff
  • djfny-menu on ogl-lin-nv: diff
  • ed-lighting on ogl-lin-nv: diff
  • fifa-street on ogl-lin-nv: diff
  • fortune-street-fog on ogl-lin-nv: diff
  • kirby-shadows on ogl-lin-nv: diff
  • luigi-shadows on ogl-lin-nv: diff
  • mario-sluggers-bar on ogl-lin-nv: diff
  • melee-lighting on ogl-lin-nv: diff
  • mii-channel on ogl-lin-nv: diff
  • mini-ninjas on ogl-lin-nv: diff
  • mkdd-efb on ogl-lin-nv: diff
  • monkeyball-fuse on ogl-lin-nv: diff
  • nfsu-reflections on ogl-lin-nv: diff
  • nsmbw-intro on ogl-lin-nv: diff
  • rs2-glass on ogl-lin-nv: diff
  • rs2-zfreeze on ogl-lin-nv: diff
  • sadx-ui on ogl-lin-nv: diff
  • smg2-fog on ogl-lin-nv: diff
  • ssbm-pointsize on ogl-lin-nv: diff
  • thps4-shadow on ogl-lin-nv: diff
  • xenoblade-menu on ogl-lin-nv: diff
  • zww-armos on ogl-lin-nv: diff
  • zww-waves on ogl-lin-nv: diff

automated-fifoci-reporter

@JMC47
Copy link
Contributor

JMC47 commented Jun 7, 2015

Yay.

@JMC47
Copy link
Contributor

JMC47 commented Jun 7, 2015

Verified to work in Tony Hawk 4, That 007 game, and Monster Hunter Tri.

Sonicadvance1 added a commit that referenced this pull request Jun 8, 2015
@Sonicadvance1 Sonicadvance1 merged commit 499478b into dolphin-emu:master Jun 8, 2015
@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 8, 2015

Um, I actually wanted to wait until I had time to implement EFB pokes
properly. But if it's this urgent then I guess it's okay.

@Sonicadvance1
Copy link
Contributor

No time like the present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants