DolphinWX: Work around modal dialog dismissal being broken in wxMac #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that the issue this is working around was raised in 2a41ac4, which switches the parent dialog from modal to non-modal, this lends itself to my theory of being a bug in wxMac. |
|
@dolphin-emu-bot rebuild |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Closing in favor of merging #2509, since it has a much more detailed analysis than my…very similar, but less in-depth analysis here, plus the patch is nearly identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nasty workaround for what I THINK is a bug in wxMac that causes a wxDialog that is modal and a child of another wxDialog to relayer improperly when dismissed.
Fixes https://code.google.com/p/dolphin-emu/issues/detail?id=8572