Interpreter: optimize NaN checks #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| double t = a * c; | ||
| if (t != t) | ||
| { | ||
| if (a != a) return a; | ||
| if (b != b) return b; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Now that I understand this, LGTM :) 👍 |
NaNs always propagate, so we can get away with only checking for NaN inputs in the rare case that the result is NaN (as already done in Jit64::HandleNaNs()).
|
LGTM |
Tilka
added a commit
that referenced
this pull request
Jun 10, 2015
Interpreter: optimize NaN checks
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
What is the performance difference? |
|
To not check all inputs for being NaNs within the interpreter. For general gameplay: none |
|
@Icekhaos Thanks for the praise, but please use this forum thread for that instead. In general, please remember that many contributors get a notification email for every single comment you post on GitHub. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaNs always propagate, so we can get away with only checking for NaN inputs in the rare case that the result is NaN (as already done in Jit64::HandleNaNs()).