New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeometryShaderGen: Don't use centroid in
for input variables.
#2588
Conversation
There are very rare conditions in which xfmem can actually desync from bpmem.
This fixes shader compilation errors on my Intel GPU. Dolphin still freezes around the point where the shader error was before, but I don't know if that's a related problem or not, because it also happens on games that didn't have any shader errors before this PR. |
@degasus Please review. |
LGTM |
GeometryShaderGen: Don't use `centroid in` for input variables.
However, It creates shader compilation errors on my AMD gpu. See Issue 8643 |
Causes issues under catalyst in Linux, and the Nvidia proprietary driver as well. |
@JosJuice Do you still have that shader dump from Intel?
|
Clearly fixing this on both Intel and other GPUs would require the vertex
shader to have knowledge about the presence of the geometry shader.
We will have to look up if the OpenGL spec really disallows the `centroid
in` qualifier in the geometry shader. If it allows those qualifiers then
I'll revert this change and disable the geometry shader on the affected
Intel drivers.
|
Intel is not conforming to the spec. |
Perhaps this behaviour is only due to interface blocks, I'll try to disable
those on Intel first.
|
No description provided.