Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometryShaderGen: Don't use centroid in for input variables. #2588

Merged
merged 2 commits into from Jun 11, 2015

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jun 10, 2015

No description provided.

@CrossVR CrossVR added the WIP / do not merge Work in progress (do not merge) label Jun 10, 2015
@CrossVR CrossVR added this to the Dolphin Release 5.0 milestone Jun 10, 2015
There are very rare conditions in which xfmem can actually desync from bpmem.
@JosJuice
Copy link
Member

This fixes shader compilation errors on my Intel GPU. Dolphin still freezes around the point where the shader error was before, but I don't know if that's a related problem or not, because it also happens on games that didn't have any shader errors before this PR.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 10, 2015

@degasus Please review.

@degasus
Copy link
Member

degasus commented Jun 11, 2015

LGTM

CrossVR added a commit that referenced this pull request Jun 11, 2015
GeometryShaderGen: Don't use `centroid in` for input variables.
@CrossVR CrossVR merged commit dca19a7 into dolphin-emu:stable Jun 11, 2015
@phire
Copy link
Member

phire commented Jun 13, 2015

However, It creates shader compilation errors on my AMD gpu.

See Issue 8643

@Sonicadvance1
Copy link
Contributor

Causes issues under catalyst in Linux, and the Nvidia proprietary driver as well.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 14, 2015 via email

@JosJuice
Copy link
Member

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 14, 2015 via email

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 14, 2015

For these inputs, "centroid in", "sample in", and interpolation
qualifiers are allowed, but are equivalent to "in".
https://www.khronos.org/registry/gles/extensions/EXT/EXT_geometry_shader.txt

Intel is not conforming to the spec.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 14, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP / do not merge Work in progress (do not merge)
5 participants