Netplay: Sync GameCube SRAM. #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
netplay-sram-sync
branch
from
7f6b051
to
abb6551
Compare
…/movie/netplay/... are read.
|
I still want to abstract all of these input sources into a standard model, but for now... seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync the GameCube SRAM and related settings of all Netplay Clients to that of the Netplay Host.
I'm not entirely sure about the
g_SRAM_netplay_initializedboolean but I can't really think of a better way to make sure the host SRAM doesn't get written to HDD on the client's side --NetPlay::IsNetPlayRunning()can be no longer true when theCEXIIPL::~CEXIIPL()destructor runs depending on how Netplay terminated. Suggestions welcome.Fixes issue 8660.