Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: trigger _assert_() in release builds #2654

Merged
merged 3 commits into from Jun 24, 2015

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jun 24, 2015

_assert_msg_() works as expected, _assert_() doesn't (see #2652). Fix that.

Also some cleanup.

Afaict, it was used to build parts of Dolphin with DSPSpy, but that's
been broken forever, so lets clean up a little bit.
@Sonicadvance1
Copy link
Contributor

Do we still use Common headers when compiling hardware test files or something?
Is that why the GEKKO check was still there?

@Tilka
Copy link
Member Author

Tilka commented Jun 24, 2015

As mentioned in the commit message, I believe it was only for DSPSpy.

@Sonicadvance1
Copy link
Contributor

ah

Sonicadvance1 added a commit that referenced this pull request Jun 24, 2015
Logging: trigger _assert_() in release builds
@Sonicadvance1 Sonicadvance1 merged commit 3c5122e into dolphin-emu:master Jun 24, 2015
@Tilka Tilka deleted the assert branch June 24, 2015 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants