Android TV: Replace toolbar on EmulationActivity with a full-screen menu #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmabeta
force-pushed
the
android-tv-ingame-menu
branch
from
f20ddb0
to
5dbe5dc
Compare
sigmabeta
force-pushed
the
android-tv-ingame-menu
branch
from
e97c216
to
12fd46e
Compare
Sonicadvance1
added a commit
that referenced
this pull request
Jul 21, 2015
Android TV: Replace toolbar on EmulationActivity with a full-screen menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android TV devices do not have a touch-screen, and so there were issues with navigating the ingame options with the controller.
It's also tough to read small text, and icons are no better. This PR adds a transparent full-screen overlay menu, while emulation continues in the background. (The settings, savestate, and loadstate options are no-ops for now, but everything else works including quicksave/load.) This menu will also be expandable to allow runtime modifications of certain settings (internal resolution, for example.)
It should be functional, but there are still visual artifacts here and there. I'm working on resolving those, as well as making the existing no-ops not no-ops anymore. However, I think there may be value in merging this asap, as it resolves a major pain point for folks trying to develop for the X1.