Interpreter: fix rounding of negating FMA instructions #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x86: round(-a*c +/- b) PowerPC: -round(a*c +/- b) If the rounding mode is set to +/- infinity, the order of round/negate matters.
|
Dropped the Jit64 commit. |
|
May ForceSingle generate NaNs? Else you could move this NaN check into the helper functions. |
|
No, but the whole point of this PR is that the negation cannot be done before rounding. |
Tilka
changed the title
degasus
added a commit
that referenced
this pull request
Jul 19, 2015
Interpreter: fix rounding of negating FMA instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rounding mode is set to +/- infinity, the order of round/negate matters.
I'm fine with dropping the Jit64 commit. It seems to work, but it doesn't exactly make the code easier to understand.