Make the LLVM detect script verify that the dynamic library actually exists. #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exists. For some dumb reason, llvm-config doesn't provide the flags to link against the dynamic library copy of LLVM (as opposed to static), so the script has to guess the library name. However, in some installations (such as mine), there is no dynamic copy, which caused Dolphin to fail to link. Change the script to do a link test. If it fails, one option would be to fall back on static linking, but I just have it fail to detect LLVM, because statically linking Dolphin against LLVM is really not a great idea - huge binary, long link time.
|
LGTM |
comex
added a commit
that referenced
this pull request
Aug 9, 2015
Make the LLVM detect script verify that the dynamic library actually exists.
comex
added a commit
that referenced
this pull request
Oct 28, 2015
Make the LLVM detect script verify that the dynamic library actually exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[I thought I submitted this quite some time ago - see commit date - but apparently not..?]]
For some dumb reason, llvm-config doesn't provide the flags to link
against the dynamic library copy of LLVM (as opposed to static), so the
script has to guess the library name. However, in some installations
(such as mine), there is no dynamic copy, which caused Dolphin to fail
to link. Change the script to do a link test. If it fails, one option
would be to fall back on static linking, but I just have it fail to
detect LLVM, because statically linking Dolphin against LLVM is really
not a great idea - huge binary, long link time.